experiment: skip Go tests on UI-only PRs#20737
Draft
davdhacs wants to merge 2 commits into
Draft
Conversation
Split UI jobs into unit-tests-ui.yaml with paths filter for ui/. Add paths-ignore: ui/** to unit-tests.yaml so Go tests skip on UI-only PRs. Add passthrough workflows that satisfy required status checks when the real workflow is skipped: - unit-tests-go-passthrough.yaml: reports go/go-postgres/go-bench/ local-roxctl check names on UI-only PRs - unit-tests-ui-passthrough.yaml: reports ui check name on non-UI PRs No ruleset changes needed — passthrough jobs use the same names as the required checks. [AI-assisted] Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
unit-tests-ui.yaml, consider adding.github/actions/job-preamble/**to thepathslist (as it was part ofrun_allbefore) so that changes to the shared preamble that affect UI tests still reliably trigger this workflow. - To fully achieve the goal of skipping Go tests for UI-only changes, you may want to align the path filters so that
.github/actions/cache-ui-dependencies/**(and any other strictly-UI infra) is included inpaths-ignorefor the Go workflow and in thepathsforunit-tests-go-passthrough.yaml, mirroring the UI workflow’s configuration.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `unit-tests-ui.yaml`, consider adding `.github/actions/job-preamble/**` to the `paths` list (as it was part of `run_all` before) so that changes to the shared preamble that affect UI tests still reliably trigger this workflow.
- To fully achieve the goal of skipping Go tests for UI-only changes, you may want to align the path filters so that `.github/actions/cache-ui-dependencies/**` (and any other strictly-UI infra) is included in `paths-ignore` for the Go workflow and in the `paths` for `unit-tests-go-passthrough.yaml`, mirroring the UI workflow’s configuration.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
🚀 Build Images ReadyImages are ready for commit bdb733f. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-1082-gbdb733f17b |
[AI-assisted] Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split unit-tests.yaml into Go and UI workflows with native
pathsfilters so UI-only PRs skip Go tests (~44 min saved) and Go-only PRs skip UI tests.Passthrough workflows with matching job names satisfy required status checks when the real workflow is skipped (GitHub leaves skipped checks as "Pending" which blocks merge).
Stacked on #20484 (container removal).
Do not merge — experiment to verify the approach works.
User-facing documentation
Testing and quality
How I validated my change
Verify that this PR (which changes only workflow YAML) triggers both the passthrough and real workflows correctly.