fix(player): normalize TS timestamp continuity#676
Merged
Conversation
8c474eb to
4b4b174
Compare
Contributor
Documentation previewThe documentation preview has been deployed for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize MPEG-TS timestamps across HLS segments and continuous TS input boundaries so playback remains continuous when upstream segments contain timestamp gaps, small overlaps, or large backward jumps.
The player now:
Root cause
TS timestamp continuity handling was split between segment-boundary orchestration, remuxing, and PCM scheduling. HLS segment resets could discard continuity state, while decoded PCM extrapolation could hide real source gaps and overlaps. This caused later HLS TS segments to stall or diverge from the media timeline even though the first segment played normally.
Implementation
The shared overlap decision and PCM range mapping live in a focused timeline module. Segment metadata now describes reset intent instead of directly commanding a remuxer reset, allowing the pipeline to distinguish TS and fMP4 behavior. MP2 raw frame typing and parser reset boundaries were also consolidated.
DevLab adds deterministic HLS and RTSP overlap, gap, restart, and packet-loss scenarios. Its README documents how browser automation must handle trusted user gestures for audible playback.
Validation
pnpm run type-checkpnpm run lintpnpm run web-ui:buildcmake -B build -DCMAKE_BUILD_TYPE=Release -DENABLE_AGGRESSIVE_OPT=ONcmake --build build -j "$(getconf _NPROCESSORS_ONLN 2>/dev/null || sysctl -n hw.ncpu)"git diff --check