feat(boil): Improve empty image version filter error#1527
Conversation
This now reports the image name and the filtered version(s) in the error. Previously, users would have to guess which image and version yielded an empty list.
There was a problem hiding this comment.
Our source of truth is https://github.com/stackabletech/operator-templating/blob/main/template/deny.toml, can you pls update that first?
There was a problem hiding this comment.
Sure, but this is not templated. So it should merge as is anyway.
There was a problem hiding this comment.
Sure, technically we could merge this PR without problems, but I want to have a single place to look to see what rustsecs we currently silence
There was a problem hiding this comment.
operator-templating PR: stackabletech/operator-templating#595
There was a problem hiding this comment.
The PR above is merged, so I assume you are now fine with this PR moving forwards?
There was a problem hiding this comment.
There actually is quite a diff between upstream and this version. Can you pls pull the upstream version into this branch? (happy to do as well)
There was a problem hiding this comment.
Sorry, I might wasn't precise enough, I meant cp ../operator-templating/template/deny.toml deny.toml
There was a problem hiding this comment.
I'm sorry, but I don't understand what you are doing 🙈
I'm talking about literally taking the template from operator-templating and pasting it here. I even gave the command 😅
Opened #1529, pls have a look
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Techassi
moved this from Development: In Review
to Development: Done
in Stackable Engineering
3 participants
This now reports the image name and the filtered version(s) in the error. Previously, users would have to guess which image and version yielded an empty list.