typo issue OffLinePayment and fix readerState issue#108
Open
cesar-sosa-hol wants to merge 1 commit into
Open
Conversation
cesar-sosa-hol
commented
Jul 10, 2026
cesar-sosa-hol
commented
Collaborator
- Fix issues reported in PR 64 about use of ReaderStatus instead old readerState
- Typo issue in OffLinePayment updated to OfflinePayment
Armaxis
reviewed
Jul 10, 2026
| let body = [ | ||
| "change": "REMOVED", | ||
| "reader": readerMap, | ||
| "readerState" : readerMap["state"], |
Member
There was a problem hiding this comment.
here and above should we read from status instead? If we're replacing state with status. Or is it already enough that it is inside the readerMap?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.