number: derive ParseInt/ParseUint bitSize from the target type#348
Open
c-tonneslan wants to merge 1 commit into
Open
number: derive ParseInt/ParseUint bitSize from the target type#348c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
parseInt and parseUint passed bitSize=0 to strconv, which means native int width. On a 32-bit platform that's 32 even when T is int64, so strings like "9223372036854775807" or "18446744073709551615" fail to round-trip through Cast (see TestNumber failures reported on armhf). Use unsafe.Sizeof(t)*8, which matches T's actual width at each generic instantiation: 8/16/32/64 for the fixed-size variants, strconv.IntSize for int/uint. Overflow detection for the smaller types is preserved. Closes spf13#310 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`parseInt`/`parseUint` passed `bitSize=0` to `strconv`, which means native int width. On a 32-bit platform that's 32 even when `T` is `int64`, so strings like `"9223372036854775807"` or `"18446744073709551615"` fail to round-trip through cast. That's the armhf `TestNumber` failure from the issue.
Switched to `unsafe.Sizeof(t)*8`, which matches `T`'s actual width at each generic instantiation (8/16/32/64 for the fixed-size variants, `strconv.IntSize` for `int`/`uint`). Overflow detection for the smaller types is preserved, and the `cast.go` call sites that pass `parseInt[T]` as a function reference don't change.
fixes #310