[Android] Fix buttons cutting of borders of their child views#4189
Open
j-piasecki wants to merge 3 commits into
Open
[Android] Fix buttons cutting of borders of their child views#4189j-piasecki wants to merge 3 commits into
j-piasecki wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Android implementation of RNGestureHandlerButton to avoid offscreen buffering when the button’s opacity is animated below 1, addressing a visual issue where child view borders get clipped at the edges.
Changes:
- Override
hasOverlappingRendering()in the Android buttonViewGroupto returnfalse. - Add an explanatory comment describing why offscreen buffering is being skipped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sets
hasOverlappingRenderingto false on the button component to prevent it from rendering on an off-screen canvas when opacity is less than 1.React Native views also set it to false by default.
Test plan
Screen.Recording.2026-05-22.at.10.11.48.mov
Screen.Recording.2026-05-22.at.10.13.05.mov