[Native] Fix buttons staying pressed in after detached from window#4188
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a native “stuck pressed” visual/interaction state for RNGestureHandlerButton when the view is detached from its window, ensuring the button resets back to its default (non-pressed) state and doesn’t block other interactions after being reattached.
Changes:
- iOS/macOS: reset button animation state on window detach.
- Android: reset button animation state on view detach and clear static responder references tied to the detached instance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/apple/RNGestureHandlerButton.mm | Resets button animation state when the control is removed from the window. |
| packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt | Resets animation state on detach and clears static responder fields so detached buttons don’t keep global responder ownership. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
736
to
+742
| override fun onDetachedFromWindow() { | ||
| super.onDetachedFromWindow() | ||
| pendingPressOut?.let { handler.removeCallbacks(it) } | ||
| pendingPressOut = null | ||
| currentAnimator?.cancel() | ||
| currentAnimator = null | ||
| applyStartAnimationState() |
Member
Author
There was a problem hiding this comment.
I think that:
isPointerInsideBoundswill reset itself inonTouchEventisTouchedshould be reset by the handler being canceledisPressedis mostly managed by the OS, and not resetting it wasn't causing us any problems in the past
tomekzaw
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clear up the button state when it's being detached from the window. This prevents the button from staying in the "pressed" state after being reattached.
It also clears up the static responder fields, so the detached buttons cannot prevent others from running interactions.
Test plan
Tested on the reproduction provided by @tomekzaw.