[Android] Accept percentage-based border radius#4185
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables percentage-based borderRadius values (e.g. '50%') for Touchable/RNGestureHandlerButton on Android by preventing ViewGroupManager from coercing radius props to Double, and instead forwarding raw values to RNGestureHandlerButtonViewManager for parsing.
Changes:
- Updates the Button native component spec to declare border radius props as
UnsafeMixedso raw values (number or percentage string) are forwarded. - Updates Android
RNGestureHandlerButtonViewManagerborder radius setters to acceptDynamicand parse viaLengthPercentage.setFromDynamic(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/specs/RNGestureHandlerButtonNativeComponent.ts | Switches border radius props to UnsafeMixed and explicitly declares non-logical radii so they route through this component’s delegate. |
| packages/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerButtonViewManager.kt | Parses border radius props from Dynamic using LengthPercentage.setFromDynamic to support percentage strings and avoid Double casting crashes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-bert
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ViewGroupManagerwhich is a base forRNGestureHandlerButtonViewManagerdoesn't support borderRadius values other thanDouble. This causesTouchableto crash when setting a percentage-based border radius. This PR changes those values to useDynamicand go throughRNGestureHandlerButtonViewManagerinstead of falling back toViewGroupManager.iOS continues to work as before.
Test plan
Before: crash, after: no crash