Skip to content

Add vault optimizations flag #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashantkumar1982 merged 8 commits into from
May 26, 2026
Merged

Add vault optimizations flag #2083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ebffc5e
Added batch pending queue items for vault
russell-stern May 15, 2026
ad71e51
Added VaultOptimizations feature flag
russell-stern May 20, 2026
2228f29
Merge branch 'main' of https://github.com/smartcontractkit/chainlink-…
russell-stern May 20, 2026
8d8b90c
Added binary shares field
russell-stern May 20, 2026
ead7c0a
Merge branch 'main' of https://github.com/smartcontractkit/chainlink-…
russell-stern May 20, 2026
c6ae1f5
Merge branch 'main' of https://github.com/smartcontractkit/chainlink-…
russell-stern May 21, 2026
b17f8e7
Added is_batch field
russell-stern May 25, 2026
a1633da
Switched to blob items instead of queue batch
russell-stern May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 94 additions & 17 deletions pkg/capabilities/actions/vault/messages.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions pkg/capabilities/actions/vault/messages.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ message SecretRequest {
message EncryptedShares {
repeated string shares = 1;
string encryption_key = 2;
repeated bytes binary_shares = 3;
Copy link
Copy Markdown
Contributor

@prashantkumar1982 prashantkumar1982 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added an optional comment on chainlink repo changes reading this field.
add a util library in this namespace to read the binary share from the EncryptedShares proto. This way it can be reused across different places.

}

message SecretData {
Expand Down Expand Up @@ -214,6 +215,14 @@ message StoredPendingQueueItem {
string id = 2;
}

// Wire format for pending queue blobs. Not persisted.
// When is_batch=false, wire-compatible with StoredPendingQueueItem (field 1 = Any, field 2 = string).
message PendingQueueBlobItems {
repeated google.protobuf.Any items = 1; // non-batch: raw payload Any; batch: each Any wraps a StoredPendingQueueItem
string id = 2; // non-batch: request ID; batch: empty
bool is_batch = 3; // disambiguates single-item from batch during unmarshalling
}

message ReportingPluginConfig {
reserved 8;

Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ flowchart
PropagateOrgIDInRequestMetadata[/PropagateOrgIDInRequestMetadata\]:::gate
VaultBase64EncodingEnabled[/VaultBase64EncodingEnabled\]:::gate
VaultForceEmptyOCRRounds[/VaultForceEmptyOCRRounds\]:::gate
VaultOptimizationsEnabled[/VaultOptimizationsEnabled\]:::gate
end

subgraph HandleNodeMessage[gatewayHandler.HandleNodeMessage]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"PropagateOrgIDInRequestMetadata": "false",
"VaultBase64EncodingEnabled": "false",
"VaultForceEmptyOCRRounds": "false",
"VaultOptimizationsEnabled": "false",
"GatewayHTTPGlobalRate": "500rps:500",
"GatewayHTTPPerNodeRate": "100rps:100",
"GatewayConfidentialRelayGlobalRate": "50rps:10",
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ VaultOrgIdAsSecretOwnerEnabled = 'false'
PropagateOrgIDInRequestMetadata = 'false'
VaultBase64EncodingEnabled = 'false'
VaultForceEmptyOCRRounds = 'false'
VaultOptimizationsEnabled = 'false'
GatewayHTTPGlobalRate = '500rps:500'
GatewayHTTPPerNodeRate = '100rps:100'
GatewayConfidentialRelayGlobalRate = '50rps:10'
Expand Down
2 changes: 2 additions & 0 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ var Default = Schema{
PropagateOrgIDInRequestMetadata: Bool(false),
VaultBase64EncodingEnabled: Bool(false),
VaultForceEmptyOCRRounds: Bool(false),
VaultOptimizationsEnabled: Bool(false),
GatewayHTTPGlobalRate: Rate(rate.Limit(500), 500),
GatewayHTTPPerNodeRate: Rate(rate.Limit(100), 100),
GatewayConfidentialRelayGlobalRate: Rate(rate.Limit(50), 10),
Expand Down Expand Up @@ -257,6 +258,7 @@ type Schema struct {
PropagateOrgIDInRequestMetadata Setting[bool]
VaultBase64EncodingEnabled Setting[bool]
VaultForceEmptyOCRRounds Setting[bool]
VaultOptimizationsEnabled Setting[bool]
GatewayHTTPGlobalRate Setting[config.Rate]
GatewayHTTPPerNodeRate Setting[config.Rate]
GatewayConfidentialRelayGlobalRate Setting[config.Rate]
Expand Down
1 change: 1 addition & 0 deletions pkg/settings/cresettings/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ func TestSchema_Unmarshal(t *testing.T) {
assert.False(t, cfg.VaultJWTAuthEnabled.DefaultValue)
assert.False(t, cfg.VaultBase64EncodingEnabled.DefaultValue)
assert.False(t, cfg.VaultForceEmptyOCRRounds.DefaultValue)
assert.False(t, cfg.VaultOptimizationsEnabled.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(20), Burst: 7}, cfg.GatewayConfidentialRelayGlobalRate.DefaultValue)
assert.Equal(t, config.Rate{Limit: rate.Limit(4), Burst: 2}, cfg.GatewayConfidentialRelayPerNodeRate.DefaultValue)
assert.Equal(t, 48*time.Hour, cfg.PerOrg.ZeroBalancePruningTimeout.DefaultValue)
Expand Down
Loading