Add raid_events=absorb#11435
Conversation
mat-simon
force-pushed
the
feature/raid-event-shield
branch
from
4803c2a to
58a8482
Compare
|
Pushed an update: added a This was originally scoped as a follow-up but I'm pulling it into this PR because a planned class-module follow-up (Voidweaver's Devour Matter) needs to gate an APL line on shield presence, and the expression is the cleanest way to expose that. Three lines added next to the No diff impact on the rest of the PR. |
| if ( incoming_state->result_absorbed > 0.0 ) | ||
| { | ||
| actual_amount = resource_loss( RESOURCE_HEALTH, incoming_state->result_amount, nullptr, incoming_action ); | ||
| actual_amount = resource_loss( RESOURCE_HEALTH, incoming_state->result_absorbed, nullptr, incoming_action ); |
There was a problem hiding this comment.
Not related specifically to this change, but the PR in general...
Historically, there were issues where some effects did not proc when the action attempting to trigger the proc was fully absorbed. The most notable case I immediately recall is Slimy Expulsion Boots during Dragonflight, most notably in Underrot (as it was available in M+ and the final boss has an absorb over its entire HP for the entire fight).
More investigation is definitely required before making this change.
mat-simon
force-pushed
the
feature/raid-event-shield
branch
from
58a8482 to
54b9ffb
Compare
mat-simon
force-pushed
the
feature/raid-event-shield
branch
from
54b9ffb to
5d04f68
Compare
mat-simon
changed the title
mat-simon
force-pushed
the
feature/raid-event-shield
branch
from
5d04f68 to
c8e31ab
Compare
mat-simon
force-pushed
the
feature/raid-event-shield
branch
from
c8e31ab to
47268b2
Compare
A new `absorb` raid event puts an absorb buff on a target enemy (target=, amount=, school= options plus standard timing controls). The raid event creates a real absorb_buff_t so it correctly absorbs damage and influences fight termination — the encounter-modeling use case, analogous to raid_event=vulnerable. When a player damages an enemy with an absorb, the attacker's stats include the absorbed portion as damage dealt, so DPS attribution reflects the rolled damage rather than only the post-absorb HP impact. This is wired in via an assessor at TARGET_DAMAGE+1, registered only when an absorb raid event is configured. Adds has_absorb() and current_absorb_amount() (virtual on player_t, defined for enemy_t) plus a target.has_absorb expression for APL queries.
mat-simon
force-pushed
the
feature/raid-event-shield
branch
from
47268b2 to
8e68709
Compare
3 participants
What
raid_events=absorb— new event that puts anabsorb_buff_ton a target enemy. Options:target=,amount=,school=plus standard timing controls. Noamount=means unbreakable for the window.target.has_absorbAPL expression andplayer_t::has_absorb()/current_absorb_amount()helpers (scoped to enemy actors viaenemy_toverrides).credited_damage_amountonplayer_t, overridden onenemy_tto add the absorbed delta.result_amountsemantics are preserved.Use case
Encounter modeling — boss / add mechanics with absorb shields (Aleria-style fights). Analogous in shape to
raid_event=vulnerable; class APLs and class modules can react to shielded targets via the helpers and thetarget.has_absorbexpression.