LT 22373: Fix reversal numbers

[aror92]

• Fix width of "Number even a single sense" message to prevent
  the final e being cut off.
• Fix position of "number even a single sense" box to prevent
  box border being cut off.
• Fix title of the configuration to say "Reversal Number
  Configuration" instead of "Sense Number Configuration"
  when configuring referenced senses in the reversal.
• Fix reversal number handling in GetSenseNumber
• Fix disappearing sense nums if reversals are toggled on/off

---

This change is 

[github-actions]

NUnit Tests

    1 files  ±0      1 suites  ±0   11m 20s ⏱️ -11s
4 187 tests ±0  4 116 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 196 runs  ±0  4 125 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit fac22e2. ± Comparison against base commit 502b832.

♻️ This comment has been updated with latest results.

[jasonleenaylor]

Src/xWorks/DictionaryDetailsController.cs line 78 at r1 (raw file):

			m_configModel = model;
			m_node = node;
			bool isReversal = DictionaryConfigurationDlg.GetTopLevelNode(node).Label == "Reversal Entry";

I feel lilke we already have an IsReversal method or property somewhere that should be usable here. We shouldn't need to make GetTopLevelNode public and do logic here. If you can't find an IsReversal method that we can use here then we should make one. I would prefer to isolate any string comparison in the config into a clear method that shows why we care about it.

[aror92]

@aror92 made 1 comment.
Reviewable status: 0 of 11 files reviewed, all discussions resolved (waiting on jasonleenaylor).

---

Src/xWorks/DictionaryDetailsController.cs line 78 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I feel lilke we already have an IsReversal method or property somewhere that should be usable here. We shouldn't need to make GetTopLevelNode public and do logic here. If you can't find an IsReversal method that we can use here then we should make one. I would prefer to isolate any string comparison in the config into a clear method that shows why we care about it.

This makes sense. You're right, there is a model.IsReversal property. Updated to use that instead. I was using GetTopLevelNode in ConfiguredLcmGenerator as well, but it's not needed there because we already have a node list and can access the root node directly. Removed that usage too, and reverted GetTopLevelNode back to private.

[jasonleenaylor]

@jasonleenaylor reviewed 11 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on aror92).