Skip to content

Serena project upgrade#816

Open
johnml1135 wants to merge 3 commits into
mainfrom
update_serena
Open

Serena project upgrade#816
johnml1135 wants to merge 3 commits into
mainfrom
update_serena

Conversation

@johnml1135
Copy link
Copy Markdown
Contributor

@johnml1135 johnml1135 commented Apr 7, 2026

Just standard upgrade to 1.0


This change is Reviewable

Copilot AI review requested due to automatic review settings April 7, 2026 13:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Serena project configuration to align with the 1.0 format/schema and refreshed documentation pointers.

Changes:

  • Refreshes the supported language list/comments and simplifies legacy/dated notes.
  • Adds/relocates project metadata and introduces new config keys (prompt, line endings, memory patterns, LS-specific settings).
  • Clarifies gitignore/ignored paths behavior and tool inclusion/exclusion comments.

Comment thread .serena/project.yml Outdated
Comment thread .serena/project.yml
Comment thread .serena/project.yml Outdated
Comment thread .serena/project.yml Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 34s ⏱️ -57s
4 187 tests ±0  4 116 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 196 runs  ±0  4 125 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 5fa568c. ± Comparison against base commit 502b832.

♻️ This comment has been updated with latest results.

Comment thread .serena/project.yml
@jasonleenaylor
Copy link
Copy Markdown
Contributor

.serena/project.yml line 59 at r2 (raw file):

  FieldWorks (FLEx) is a Windows-first linguistics suite by SIL International.
  Key build facts:
  - Uses MSBuild Traversal SDK via FieldWorks.proj (21 ordered phases, 110+ projects)

This statement about phases is not accurate.

@jasonleenaylor
Copy link
Copy Markdown
Contributor

.serena/project.yml line 59 at r2 (raw file):

  FieldWorks (FLEx) is a Windows-first linguistics suite by SIL International.
  Key build facts:
  - Uses MSBuild Traversal SDK via FieldWorks.proj (21 ordered phases, 110+ projects)

All the comments here about phases are incorrect now I think. I think the 'phases' wording just needs to be dropped.

johnml1135 and others added 2 commits May 12, 2026 09:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@johnml1135
Copy link
Copy Markdown
Contributor Author

Addressed the open review points in 5fa568c1a.

Responses by topic:

  • line_ending: stays blank intentionally. I checked the Serena 1.0 template/parser behavior and blank line_ending means "inherit the global setting", so that comment was informational but not actionable here.
  • The shared project_name: FieldWorks was removed from .serena/project.yml. For this repo, a committed fixed project name is the wrong default because multiple worktrees can register ambiguously. The shared config now falls back to the worktree folder name, and .serena/project.local.yml is the place for any explicit local override.
  • Related to that, .serena/project.local.yml is now ignored and Docs/mcp.md documents the per-worktree override pattern.
  • The brittle phase/count wording in initial_prompt was replaced with stable repo facts, which also addresses the comments about the phase wording being inaccurate.
  • Build/Agent/Setup-Serena.ps1 now understands the Serena 1.0 languages: block and reports the worktree-folder fallback when project_name is omitted.
  • On the comment-placement question: I kept the explanatory comments adjacent to the fields they describe so the file stays aligned with Serena’s 1.0 template structure.

If anyone wants a different local naming convention for Serena, the intended path now is .serena/project.local.yml, not the shared tracked config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants