-
Notifications
You must be signed in to change notification settings - Fork 31
Initial commit of prototype converter for Rohde and Schwarz IQ.TAR #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
KelseyCreekSoftware
wants to merge
15
commits into
sigmf:main
Choose a base branch
from
KelseyCreekSoftware:feature/rohdeschwarz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cff5af6
Initial commit of prototype converter for Rohde and Schwarz IQ.TAR fi…
KelseyCreekSoftware 3ad18dc
Working on Codacy security code issues.
KelseyCreekSoftware 09fd807
Adding mainly AI created pytest that seems to work.
KelseyCreekSoftware 84a6d18
Updating byte offset for MagicBytes function.
KelseyCreekSoftware d85c82e
Adding additional flexibility for R&S XML - extend get_magic_bytes wi…
KelseyCreekSoftware 2300d7d
Adding support for Python 3.9 with use of Optional.
KelseyCreekSoftware 750c38e
Minor updates- need to merge in main to catch up on latest sigmf work
KelseyCreekSoftware 6d2977f
Minor updates- need to merge in main to catch up on latest sigmf work
KelseyCreekSoftware bd190c0
Merge branch 'main' into feature/rohdeschwarz
KelseyCreekSoftware 18c2209
Working on R&S converter fixes and updates.
KelseyCreekSoftware 8bb2a50
Starting work on Co-Pilot code review. More to do here!
KelseyCreekSoftware c52499c
Ignore .venv environment file
KelseyCreekSoftware 4557098
Fixing meta.to file signature to add overwrite.
KelseyCreekSoftware 8082165
Additional work on Co-Pilot code review. One more fix to do.
KelseyCreekSoftware 9e90017
Completed all Co-pilot review items, and then used Claude Haiku 4.5 t…
KelseyCreekSoftware File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,4 @@ docs/source/_autosummary/ | |
|
|
||
| # dev related | ||
| .vscode/ | ||
| .venv/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,17 +14,17 @@ | |
| from .. import __version__ as toolversion | ||
| from ..error import SigMFConversionError | ||
| from . import detect_converter | ||
| from .wav import wav_to_sigmf | ||
| from .blue import blue_to_sigmf | ||
| from .signalhound import signalhound_to_sigmf | ||
| from .wav import wav_to_sigmf | ||
|
|
||
| from .rohdeschwarz import rohdeschwarz_to_sigmf | ||
|
Comment on lines
16
to
+20
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed. |
||
|
|
||
| def main() -> None: | ||
| """ | ||
| Unified entry-point for SigMF conversion of non-SigMF recordings. | ||
|
|
||
| This command-line interface converts various non-SigMF file formats into SigMF-compliant datasets. | ||
| It currently supports WAV and BLUE/Platinum file formats. | ||
| It currently supports WAV and BLUE/Platinum, Signal Hound Spike and Rohde and Schwarz IQ.TAR file formats. | ||
| The converter detects the file type based on magic bytes and invokes the appropriate conversion function. | ||
|
|
||
| By default it will output a SigMF pair (.sigmf-meta and .sigmf-data). | ||
|
|
@@ -94,10 +94,9 @@ def main() -> None: | |
| elif converter_type == "blue": | ||
| _ = blue_to_sigmf(blue_path=input_path, out_path=output_path, create_archive=args.archive, create_ncd=args.ncd) | ||
| elif converter_type == "signalhound": | ||
| _ = signalhound_to_sigmf( | ||
| signalhound_path=input_path, out_path=output_path, create_archive=args.archive, create_ncd=args.ncd | ||
| ) | ||
|
|
||
| _ = signalhound_to_sigmf(signalhound_path=input_path, out_path=output_path, create_archive=args.archive, create_ncd=args.ncd) | ||
| elif converter_type == "rohdeschwarz": | ||
| _ = rohdeschwarz_to_sigmf(rohdeschwarz_path=input_path, out_path=output_path, create_archive=args.archive, create_ncd=args.ncd) | ||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be more work to do here, but not sure the recommended solution is worth the additional code.
Once everything is basically working, it would be good to do a code pass for efficiency. Having very large files, of all types, to test would also be good to make sure the magic bytes are locatable.