SG-43677 Fix hooks to support multiple keyword arguments#144
Merged
carlos-villavicencio-adsk merged 1 commit intoJun 11, 2026
Merged
Conversation
This was referenced Jun 11, 2026
julien-lang
reviewed
Jun 11, 2026
Member
There was a problem hiding this comment.
Should we remove this file? I'm surprised we missed it!
| # public interface - to be overridden by deriving classes | ||
|
|
||
| def generate_actions(self, sg_publish_data, actions, ui_area): | ||
| def generate_actions(self, sg_publish_data, actions, ui_area, **kwargs): |
Contributor
Author
There was a problem hiding this comment.
Because I'm injecting a new argument to the hook for flowam integration to work.
This is not needed on all DCCs (i.e. 3ds, photoshop) but it crashes due to the unexpected argument. So this is just adding the placeholder.
You can see the difference on this file and compare it to tk-maya_actions.py to have a better picture.
3 tasks
Contributor
Author
|
Merging this. Any further updates can be done against #137 |
carlos-villavicencio-adsk
merged commit 777b988
into
ticket/SG-43456_migration_1
12 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base branch: #137
DCCs that are not supported with FlowAM integration crashes their hooks due to unexpected arguments. This PRs addresses this issue by just adding
**kwargsand silently ignoring them when not needed.