Skip to content

Fix installer chrome-sandbox path handling #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Coolmaciek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix installer chrome-sandbox path handling #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ The installer:
- Installs a wrapper at `/usr/local/bin/linear`, a desktop entry, and the Linear icon into the system icon cache.
- Accepts overrides: `VERSION=0.2.5 APPIMAGE_URL=<url> INSTALL_ROOT=/opt ./installer.sh`

Recent fix:
- Removed a stale hardcoded `/opt/Linear/chrome-sandbox` step that could print a missing-file warning on successful installs.

Development:
- `npm start` launches Electron with sandbox disabled for local runs (packaged builds use the proper setuid helper).
- `npm run build` produces an AppImage that bundles the Linear brand assets for the desktop icon.
Expand Down
4 changes: 0 additions & 4 deletions installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,5 @@ sudo install -Dm644 "${ICON_SVG}" /usr/share/icons/hicolor/scalable/apps/linear.
sudo install -Dm644 "${ICON_PNG}" /usr/share/icons/hicolor/512x512/apps/linear.png
sudo gtk-update-icon-cache -f /usr/share/icons/hicolor || true

echo "Configuring chrome sandbox"

sudo chown root:root /opt/Linear/chrome-sandbox || true
sudo chmod 4755 /opt/Linear/chrome-sandbox || true

echo "Linear ${VERSION} installed. Launch with: ${WRAPPER_PATH}"