Fixed an error where the service request to get all faults with include_muted=false also returned the muted faults.

[evTessellate]

Pull Request

Summary

The gateway returns a list of muted faults even when the service request ask to exclude them. It caused the web UI and Foxglove to display muted faults even if muting correlation rules where defined.

---

Issue

Link the related issue (required):

• closes [BUG] Muted faults appears in the web UI and Foxglove #413

---

Type

• Bug fix
• New feature or tests
• Breaking change
• Documentation only

---

Testing

How was this tested / how should reviewers verify it?
As described in the #413 issue, I created a small setup with a MAIN_FAULT and a CASCADED_FAULT where the former should mute the later based on a hierarchical correlation_rule. The same setup was used to resolve the problem. I used the Foxglove plugin to validate that with the changes the CASCADED_FAULT didn't appear in the UI. Also curl "http://localhost:8080/api/v1/faults?include_muted=false" now excludes the muted faults while `curl "http://localhost:8080/api/v1/faults?include_muted=true" keeps it.

---

Checklist

• Breaking changes are clearly described (and announced in docs / changelog if needed)
• Tests were added or updated if needed
• Docs were updated if behavior or public API changed

[bburda]

Thanks for the fix @evTessellate, root cause is spot on. Merging.