Rename to microkit_cspace_root_slot_to_cptr#524
Merged
Conversation
This reflects the intended usecase of this. Signed-off-by: Julia Vassiliki <julia.vassiliki@unsw.edu.au>
Indanz
reviewed
Jun 12, 2026
Indanz
left a comment
Indanz
left a comment
There was a problem hiding this comment.
This change breaks all existing user space using this function for no good reason.
Collaborator
Author
I merged it yesterday night. I doubt anybody has started using this function since then, especially given that there has been no release. |
Indanz
reviewed
Jun 12, 2026
Comment on lines
+519
to
521
| static inline seL4_CPtr microkit_cspace_root_slot_to_cptr(seL4_Word slot) | ||
| { | ||
| if (slot > MICROKIT_MAX_USER_CAPS) { |
There was a problem hiding this comment.
Hm, shouldn't this be:
if (slot >= MICROKIT_MAX_USER_CAPS) {
Oh, in that case, don't mind me and carry on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reflects the intended usecase of this.