libmicrokit: fix deferred signal dropping on reply#523
Merged
Conversation
dreamliner787-9
force-pushed
the
deferred_fix
branch
from
cabf028 to
a9fc15d
Compare
Previously, the event loop does not consider the case where you have both a reply and signal pending. In that case, Microkit would send the reply but not the signal until the next iteration of the event loop, or it won't send the deferred signal at all depending on the circumstances. This commit added a check for this case. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
dreamliner787-9
force-pushed
the
deferred_fix
branch
from
a9fc15d to
d7dbe83
Compare
midnightveil
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the event loop does not consider the case where you have both a reply and signal pending. In that case, Microkit would send the reply but not the signal until the next iteration of the event loop, or it won't send the deferred signal at all depending on the circumstances. This commit added a check for this case.