Skip to content

Add plot_disp_ests()#1004

Merged
Zethson merged 18 commits into
scverse:mainfrom
LuisHeinzlmeier:feature/add-plot-disp-ests
Jun 2, 2026
Merged

Add plot_disp_ests()#1004
Zethson merged 18 commits into
scverse:mainfrom
LuisHeinzlmeier:feature/add-plot-disp-ests

Conversation

@LuisHeinzlmeier
Copy link
Copy Markdown
Collaborator

@LuisHeinzlmeier LuisHeinzlmeier changed the title Feature/add plot disp ests Add plot_disp_ests() Jun 1, 2026
Copy link
Copy Markdown
Collaborator Author

@LuisHeinzlmeier LuisHeinzlmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was branched from PR #974 and currently contains all these changes. As soon as we merge #974, this one should be ready for a review.

I noticed that pyseq2 already has a very basic dispersion plot function, and I was wondering if I should also add the function there?

@LuisHeinzlmeier LuisHeinzlmeier requested a review from Zethson June 1, 2026 10:52
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.79%. Comparing base (12897e1) to head (89c1af5).
⚠️ Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
+ Coverage   73.54%   77.79%   +4.24%     
==========================================
  Files          48       48              
  Lines        5613     6376     +763     
==========================================
+ Hits         4128     4960     +832     
+ Misses       1485     1416      -69     
Files with missing lines Coverage Δ
...y/tools/_differential_gene_expression/_pydeseq2.py 91.66% <100.00%> (-0.23%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Zethson Zethson marked this pull request as ready for review June 1, 2026 18:30
Comment thread pertpy/tools/_differential_gene_expression/_pydeseq2.py
Comment thread pertpy/tools/_differential_gene_expression/_pydeseq2.py Outdated
Comment thread pertpy/tools/_differential_gene_expression/_pydeseq2.py
@LuisHeinzlmeier LuisHeinzlmeier requested a review from Zethson June 2, 2026 05:07
@Zethson
Copy link
Copy Markdown
Member

Zethson commented Jun 2, 2026

I noticed that pyseq2 already has a very basic dispersion plot function, and I was wondering if I should also add the function there?

No, not necessary for now.

Copy link
Copy Markdown
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Zethson Zethson merged commit a0a81cc into scverse:main Jun 2, 2026
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants