ci: drop skill docs staleness check, keep generation smoke test#218
Merged
Conversation
The Linux keyring backend gated availability on the exit code of `secret-tool --version`, but that flag has never existed in any release of libsecret (including master). On every Linux system, `secret-tool --version` prints usage and exits 2, so isAvailable() always returned false and 'linear auth login' failed with 'No system keyring found', even when gnome-keyring-daemon was running fine. Drop the version probe and rely on the existing lookup probe, plus an explicit check for the well-known 'was not provided by any .service files' stderr that secret-tool emits when no Secret Service is registered on the session bus. This matches the shape of the existing test/keyring.integration.test.ts isKeyringAvailable() helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill docs check was failing because
Deno.consoleSize()returns different values depending on the runner's pseudo-terminal dimensions (CI is wide, local terminals vary). Since the docs are for LLM consumption and not correctness, dropping thegit diffcheck and just verifying generation doesn't crash.