Skip to content

feat(cockpit): add alloy config snippet generation for metrics, logs and traces#5638

Draft
jremy42 wants to merge 5 commits into
mainfrom
feat/cockpit-config-alloy
Draft

feat(cockpit): add alloy config snippet generation for metrics, logs and traces#5638
jremy42 wants to merge 5 commits into
mainfrom
feat/cockpit-config-alloy

Conversation

@jremy42

@jremy42 jremy42 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

close #5498

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@jremy42 jremy42 requested review from a team and remyleone as code owners June 4, 2026 14:23
@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 43.75000% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.64%. Comparing base (6104780) to head (f5fb495).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nternal/namespaces/cockpit/v1/custom_config_get.go 0.00% 42 Missing ⚠️
...ernal/namespaces/cockpit/v1/custom_config_alloy.go 67.92% 13 Missing and 4 partials ⚠️
...spaces/cockpit/v1/custom_config_alloy_templates.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5638      +/-   ##
==========================================
- Coverage   50.65%   50.64%   -0.01%     
==========================================
  Files         340      342       +2     
  Lines       78127    78238     +111     
==========================================
+ Hits        39577    39626      +49     
- Misses      37054    37110      +56     
- Partials     1496     1502       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

remoteWriteURL := BuildPrometheusRemoteWriteURL(dataSourceURL)

lines := make([]string, 0, 28)
lines = append(lines,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would strongly prefer having a template file that could be rendered and with a proper type comment

@remyleone remyleone marked this pull request as draft June 15, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for configuring alloy for metrics, logs and traces

3 participants