Skip to content

feat(object): add support for 's3-endpoint' to bucket cmds#5636

Draft
pypaut wants to merge 11 commits into
scaleway:mainfrom
pypaut:feat/s3-endpoint
Draft

feat(object): add support for 's3-endpoint' to bucket cmds#5636
pypaut wants to merge 11 commits into
scaleway:mainfrom
pypaut:feat/s3-endpoint

Conversation

@pypaut

@pypaut pypaut commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5568.

This PR depends on scaleway/scaleway-sdk-go#3100.

Release note for CHANGELOG:

Add an `s3-endpoint` flag to the bucket commands
Add support for `s3_endpoint` specified in the configuration profile

@pypaut pypaut self-assigned this Jun 4, 2026
@pypaut pypaut changed the title feat(object): add 's3-endpoint' to bucket cmds feat(object): add 's3-endpoint' flag to bucket cmds Jun 4, 2026
@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.13793% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.79%. Comparing base (68a9cb3) to head (fab68ff).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/namespaces/object/v1/custom_bucket.go 77.77% 6 Missing and 6 partials ⚠️
internal/namespaces/object/v1/s3_helpers.go 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5636      +/-   ##
==========================================
+ Coverage   50.78%   50.79%   +0.01%     
==========================================
  Files         340      340              
  Lines       77934    77971      +37     
==========================================
+ Hits        39577    39605      +28     
- Misses      36861    36865       +4     
- Partials     1496     1501       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pypaut pypaut force-pushed the feat/s3-endpoint branch from 8934206 to fab68ff Compare June 8, 2026 14:39
@pypaut pypaut marked this pull request as ready for review June 8, 2026 14:40
@pypaut pypaut requested review from a team and remyleone as code owners June 8, 2026 14:40
@pypaut pypaut marked this pull request as draft June 8, 2026 15:15
@pypaut

pypaut commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Doesn't build because it relies on an SDK version that is not live yet.

@pypaut pypaut changed the title feat(object): add 's3-endpoint' flag to bucket cmds feat(object): add support for 's3-endpoint' to bucket cmds Jun 9, 2026
@pypaut pypaut added the priority:medium Improvements that are not the main priority label Jun 18, 2026
@pypaut pypaut force-pushed the feat/s3-endpoint branch from 78ae589 to d02bb3f Compare June 29, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Improvements that are not the main priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for overriding endpoints for object storage

2 participants