fix: make GitHub Link pagination parsing linear#189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the uncontrolled GitHub
Link-header regex with a small linear parser shared by the primary GitHub client and GHAS pagination. Move the three existing credential-storage false-positive annotations to CodeQL's effective preceding-line form.Why
CodeQL alert #407 identified polynomial regex behavior on an API-controlled
Linkheader. The same fallback existed in the GHAS path. Large malformed headers must fail closed without invoking a backtracking regex, while valid GitHub pagination must continue to work.Review Of What Was Built
rel=nextparser.requests.Response.linksas the preferred parser.Cleanup Review
Removed both copies of the polynomial Link-header regex. No API, output, scheduler, portfolio-truth, or collection behavior was broadened.
Verification Summary
git diff --check: passed.Shipped Summary
On this branch, attacker-controlled Link headers cannot reach the flagged regex, malformed headers fail closed, and valid fallback pagination remains compatible.
Next Phase
Let CodeQL verify alert #407 no longer reproduces. After merge, classify the three guarded storage alerts as false positives using their existing regression evidence and refresh the bounded security receipt.
Remaining Roadmap
AIGCCore's historical CodeReviewID finding remains visible until genuinely reviewed future changes rotate the unreviewed commit window.