Remove old docs regarding the "maintain" role#2500
Merged
Conversation
This removes the old docs for the "maintain" role and how it relates to using bors. There are multiple reasons: - Since switching to rulesets, users with "maintain" role can no longer override the protections. Rulesets behave differently than branch protections, and require explicitly listing who can bypass the rulset. - This was only really relevant when using bors, and we generally only have one repository now that does that (rust-lang/rust), so it is not relevant to most users. - The way it was written was confusing, since it implied users with "write" couldn't merge. What it meant to say is that users with "maintain" can override the protections (which per the first point is no longer true anyways).
Dry-run check results |
Contributor
Author
|
@jieyouxu Does it make sense why this PR triggered so many edits? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the old docs for the "maintain" role and how it relates to using bors. There are multiple reasons: