Skip to content

Remove old docs regarding the "maintain" role#2500

Merged
jieyouxu merged 1 commit into
rust-lang:mainfrom
ehuss:docs-maintain-role
Jun 2, 2026
Merged

Remove old docs regarding the "maintain" role#2500
jieyouxu merged 1 commit into
rust-lang:mainfrom
ehuss:docs-maintain-role

Conversation

@ehuss
Copy link
Copy Markdown
Contributor

@ehuss ehuss commented Jun 2, 2026

This removes the old docs for the "maintain" role and how it relates to using bors. There are multiple reasons:

  • Since switching to rulesets, users with "maintain" role can no longer override the protections. Rulesets behave differently than branch protections, and require explicitly listing who can bypass the rulset.
  • This was only really relevant when using bors, and we generally only have one repository now that does that (rust-lang/rust), so it is not relevant to most users.
  • The way it was written was confusing, since it implied users with "write" couldn't merge. What it meant to say is that users with "maintain" can override the protections (which per the first point is no longer true anyways).

This removes the old docs for the "maintain" role and how it relates to
using bors. There are multiple reasons:

- Since switching to rulesets, users with "maintain" role can no longer
  override the protections. Rulesets behave differently than branch
  protections, and require explicitly listing who can bypass the rulset.
- This was only really relevant when using bors, and we generally only
  have one repository now that does that (rust-lang/rust), so it is not
  relevant to most users.
- The way it was written was confusing, since it implied users with
  "write" couldn't merge. What it meant to say is that users with
  "maintain" can override the protections (which per the first point is
  no longer true anyways).
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu jieyouxu added this pull request to the merge queue Jun 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github
[INFO  rust_team::sync] 💻 Team Diffs:
    📝 Editing team 'rust-lang/project-assumptions-on-binders':
      Deleting member 'rust-lang-owner'
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/project-assumptions-on-binders':
      Environments:
        🔄 Update: github-pages
            Removing branches: main

Merged via the queue into rust-lang:main with commit 59b85f7 Jun 2, 2026
4 checks passed
@ehuss
Copy link
Copy Markdown
Contributor Author

ehuss commented Jun 2, 2026

@jieyouxu Does it make sense why this PR triggered so many edits?

 rust_team::sync] synchronizing github
 rust_team::sync] 💻 Team Diffs:
    📝 Editing team 'rust-lang/project-assumptions-on-binders':
      Deleting member 'rust-lang-owner'
    💻 Repo Diffs:
    📝 Editing repo 'rust-lang/project-assumptions-on-binders':
      Environments:
        🔄 Update: github-pages
            Removing branches: main
    📝 Editing repo 'rust-lang/rust':
      Rulesets:
          Updating 'stable'
            Bypass Actors: [RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }] => [RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }]
          Updating 'beta'
            Bypass Actors: [RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }] => [RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }]
          Updating '*'
            Bypass Actors: [RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 16787004, actor_type: Team, bypass_mode: Always }] => [RulesetBypassActor { actor_id: 16787004, actor_type: Team, bypass_mode: Always }, RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }]
          Updating '*/**/*'
            Bypass Actors: [RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }] => [RulesetBypassActor { actor_id: 278306, actor_type: Integration, bypass_mode: Always }, RulesetBypassActor { actor_id: 217112, actor_type: Integration, bypass_mode: Always }]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants