Change `is_some_and` to take by value by camsteffen · Pull Request #98354 · rust-lang/rust

camsteffen · 2022-06-21T20:00:51Z

Consistent with other function-accepting Option methods.

Tracking issue: #93050

rust-highfive · 2022-06-21T20:00:54Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Xiretza · 2022-06-21T20:06:38Z

Option::is_some and Option::is_none take &self. I'd say this function is more similar to those than, say, unwrap_or_else(), which actually gives you the value contained in the option.

m-ou-se · 2022-06-21T20:26:39Z

This seems like a discusssion to have on the tracking issue and get consensus on first.

(I personally think it'd be confusing if an is_ method would consume the Option, and we should be consistent with is_some.)

camsteffen · 2022-07-28T21:53:30Z

Reopening per #99087 (comment). I need to change is_ok_and,is_err_and too.

rustbot · 2022-07-28T22:16:37Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

camsteffen · 2022-07-28T22:18:08Z

Also changed the feature name. Not sure if that is wanted.

bors · 2022-08-22T14:58:03Z

☔ The latest upstream changes (presumably #99702) made this pull request unmergeable. Please resolve the merge conflicts.

m-ou-se

Thanks! r=me after rebasing.

camsteffen · 2022-09-28T23:43:36Z

@bors r=m-ou-se

bors · 2022-09-28T23:43:37Z

📌 Commit d88463b363684fdff191a19355ebe108e20500f4 has been approved by m-ou-se

It is now in the queue for this repository.

rustbot · 2022-09-28T23:44:38Z

The Miri subtree was changed

cc @rust-lang/miri

camsteffen · 2022-09-28T23:44:41Z

@bors r=m-ou-se

bors · 2022-09-28T23:44:42Z

📌 Commit 596176dd74dce4c5d43155c09fcfa81be118dce8 has been approved by m-ou-se

It is now in the queue for this repository.

bors · 2022-09-29T01:09:55Z

⌛ Testing commit 596176dd74dce4c5d43155c09fcfa81be118dce8 with merge 9feea309bae62e17e247b52e80b3c32f90c19891...

bors · 2022-09-29T01:27:38Z

💔 Test failed - checks-actions

camsteffen · 2022-09-29T01:53:45Z

@bors retry

camsteffen · 2022-10-01T16:47:44Z

@bors r=m-ou-se

bors · 2022-10-01T16:47:46Z

📌 Commit 4f12de0 has been approved by m-ou-se

It is now in the queue for this repository.

bors · 2022-10-02T12:48:19Z

⌛ Testing commit 4f12de0 with merge 91931ec...

bors · 2022-10-02T15:30:59Z

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 91931ec to master...

rust-timer · 2022-10-02T17:26:43Z

Finished benchmarking commit (91931ec): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[3.4%, 5.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.1%	[-9.0%, -3.0%]	4
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

the arithmetic mean of the percent change ↩
number of relevant changes ↩

…ou-se Change `is_some_and` to take by value Consistent with other function-accepting `Option` methods. Tracking issue: rust-lang#93050 r? `@m-ou-se`

Natural-selection1 · 2025-04-23T01:19:34Z

@camsteffen Hello, I'd like to know why the query function is designed to be passed by value?

(Ignore this one because I already found the answer at #93050

rust-highfive assigned m-ou-se Jun 21, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 21, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2022

m-ou-se closed this Jun 21, 2022

camsteffen reopened this Jul 28, 2022

camsteffen force-pushed the is-some-and-by-value branch from dc6f6e3 to 81ad37c Compare July 28, 2022 22:16

camsteffen mentioned this pull request Jul 30, 2022

is_some_and taking self demo #99087

Closed

m-ou-se approved these changes Sep 27, 2022

View reviewed changes

m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2022

camsteffen force-pushed the is-some-and-by-value branch from 81ad37c to d88463b Compare September 28, 2022 23:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2022

camsteffen force-pushed the is-some-and-by-value branch from d88463b to 596176d Compare September 28, 2022 23:44

bors mentioned this pull request Sep 29, 2022

errors: rename typeck.ftl to hir_analysis.ftl #102395

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 29, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2022

This comment has been minimized.

Sign in to view

camsteffen added 2 commits October 1, 2022 11:45

Change is_some_and to take by value

2f83134

Change feature name to is_some_and

4f12de0

camsteffen force-pushed the is-some-and-by-value branch from 65bb1e2 to 4f12de0 Compare October 1, 2022 16:46

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 2, 2022

bors merged commit 91931ec into rust-lang:master Oct 2, 2022

rustbot added this to the 1.66.0 milestone Oct 2, 2022

camsteffen deleted the is-some-and-by-value branch October 2, 2022 21:28

VuiMuich mentioned this pull request Dec 12, 2022

LeftWM crashes because current_exe() is not supported in OpenBSD leftwm/leftwm#983

Closed

m-ou-se mentioned this pull request Mar 7, 2023

Tracking Issue for Option::is_some_and and Result::is_{ok,err}_and #93050

Closed

8 tasks

Natural-selection1 mentioned this pull request Apr 23, 2025

Update the index of Option to make the summary more comprehensive #138957

Merged

Uh oh!

Conversation

camsteffen commented Jun 21, 2022

Uh oh!

rust-highfive commented Jun 21, 2022

Uh oh!

Xiretza commented Jun 21, 2022

Uh oh!

m-ou-se commented Jun 21, 2022

Uh oh!

camsteffen commented Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 28, 2022

Uh oh!

camsteffen commented Jul 28, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

m-ou-se left a comment

Choose a reason for hiding this comment

Uh oh!

camsteffen commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

rustbot commented Sep 28, 2022

Uh oh!

camsteffen commented Sep 28, 2022

Uh oh!

bors commented Sep 28, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

bors commented Sep 29, 2022

Uh oh!

camsteffen commented Sep 29, 2022

Uh oh!

This comment has been minimized.

camsteffen commented Oct 1, 2022

Uh oh!

bors commented Oct 1, 2022

Uh oh!

bors commented Oct 2, 2022

Uh oh!

bors commented Oct 2, 2022

Uh oh!

rust-timer commented Oct 2, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Natural-selection1 commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

camsteffen commented Jul 28, 2022 •

edited

Loading

Natural-selection1 commented Apr 23, 2025 •

edited

Loading