Skip to content

rustdoc: Resolve some more doc links early#96261

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:doclink7
Apr 22, 2022
Merged

rustdoc: Resolve some more doc links early#96261
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:doclink7

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Trying another subset of #94857 that is not too expensive.

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 20, 2022
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2022
@petrochenkov

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 20, 2022
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2022
@bors

bors commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

⌛ Trying commit e0b71ff with merge bd0e0e462384317dff100d42939285d5a16e4e9b...

@bors

bors commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: bd0e0e462384317dff100d42939285d5a16e4e9b (bd0e0e462384317dff100d42939285d5a16e4e9b)

@rust-timer

Copy link
Copy Markdown
Collaborator

Queued bd0e0e462384317dff100d42939285d5a16e4e9b with parent 51ea9bb, future comparison URL.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (bd0e0e462384317dff100d42939285d5a16e4e9b): comparison url.

Summary:

  • Primary benchmarks: mixed results
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 1 0 13 22 14
mean2 2.7% N/A -2.2% -3.4% -1.9%
max 2.7% N/A -4.9% -5.4% -4.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 21, 2022
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
@Kobzol

Kobzol commented Apr 21, 2022

Copy link
Copy Markdown
Member

syn is quite noisy lately, so the regression might be a fluke.

@GuillaumeGomez

Copy link
Copy Markdown
Member

Does it fix the missing call to unindent_comment from your topic in zulip?

@petrochenkov petrochenkov changed the title [WIP] rustdoc: Resolve some more doc links early rustdoc: Resolve some more doc links early Apr 21, 2022
@petrochenkov

Copy link
Copy Markdown
Contributor Author

@GuillaumeGomez

Does it fix the missing call to unindent_comment from your topic in zulip?

No, I'll submit that change later.

Let's actually land this, it's a pure performance win, and a relatively large one, and I won't be able to work on other parts of #94857 until the next week.
This can be rolled up with #96260 to save CI time.
@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 21, 2022
@GuillaumeGomez

GuillaumeGomez commented Apr 21, 2022

Copy link
Copy Markdown
Member

Thanks! I prefer to keep perf improvements merged on their own so we can track them more efficiently.

@bors r+ rollup=never

@bors

bors commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit e0b71ff has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2022
@bors

bors commented Apr 22, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e0b71ff with merge 0b3404b...

@bors

bors commented Apr 22, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 0b3404b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2022
@bors bors merged commit 0b3404b into rust-lang:master Apr 22, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 22, 2022
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0b3404b): comparison url.

Summary:

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)
Regressions 😿
(secondary)
Improvements 🎉
(primary)
Improvements 🎉
(secondary)
All 😿 🎉
(primary)
count1 0 0 14 22 14
mean2 N/A N/A -2.2% -3.4% -2.2%
max N/A N/A -4.9% -5.4% -4.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes

  2. the arithmetic mean of the percent change

@rustbot rustbot removed the perf-regression Performance regression. label Apr 22, 2022
@petrochenkov petrochenkov deleted the doclink7 branch February 22, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants