Document unsafety in library/core/src/slice/mod.rs#75066
Merged
bors merged 6 commits intoAug 12, 2020
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
LukasKalbertodt
suggested changes
Aug 8, 2020
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall! I have added some inline comments, some of which are only small nits.
LukasKalbertodt
suggested changes
Aug 8, 2020
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick update and for not amending/force-pushing -- a separate commit makes reviewing updates for these kinds of PRs a lot easier.
Three inline comments still.
LukasKalbertodt
suggested changes
Aug 10, 2020
LukasKalbertodt
left a comment
LukasKalbertodt
left a comment
Contributor
There was a problem hiding this comment.
Just one point left!
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Aug 12, 2020
…y-comments, r=Mark-Simulacrum Accept more safety comments This accepts more `// SAFETY:` comments from `tidy`. This is done after the current behaviour of requiring text one the same line (because spaces are stripped so the last space never pass if there is no text on the same line) bit me once more in rust-lang#75066 This could potentially accept empty `// SAFETY:` comments but `tidy` is an internal tool used only here so my reasoning is reviews will catch those.
Contributor
|
@bors r+ rollup=iffy Again, thanks a lot! |
Collaborator
|
📌 Commit a308e74 has been approved by |
Collaborator
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Member
|
@bors treeclosed- |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restart where #73555 left off, helping with #66219.