when bailing on ambiguity, don't force other results to ambig

[lcnr]

a smaller version of #149904 which doesn't cause the perf issue in bevy, or at least in the minimization

Fixes rust-lang/trait-system-refactor-initiative#257, does not fix all of binius_field, the remaining issues are tracked in rust-lang/trait-system-refactor-initiative#274

r? BoxyUwU

[rustbot]

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

[lcnr]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 6dcb6cd (6dcb6cdb85235ac3bf5e6e6ac173e11b5cf57ad2, parent: b806d39f033b05ea5aec9a353df75314007a728c)

[rust-timer]

Finished benchmarking commit (6dcb6cd): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.8%	[2.1%, 7.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	49
Regressions ❌ (secondary)	0.1%	[0.0%, 0.2%]	23
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	49

Bootstrap: 489.748s -> 489.291s (-0.09%)
Artifact size: 393.29 MiB -> 393.40 MiB (0.03%)

[rust-bors]

☔ The latest upstream changes (presumably #155443) made this pull request unmergeable. Please resolve the merge conflicts.

[BoxyUwU]

i am missing context here, we should sync call about it

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.