Skip to content

Rename std::fs::try_exists to std::fs::exists and stabilize fs_try_exists#126140

Merged
bors merged 1 commit into
rust-lang:masterfrom
eduardosm:stabilize-fs_try_exists
Jun 22, 2024
Merged

Rename std::fs::try_exists to std::fs::exists and stabilize fs_try_exists#126140
bors merged 1 commit into
rust-lang:masterfrom
eduardosm:stabilize-fs_try_exists

Conversation

@eduardosm

@eduardosm eduardosm commented Jun 7, 2024

Copy link
Copy Markdown
Contributor

FCP completed in tracking issue.

Tracking issue: #83186

Closes #83186

Stabilized API:

mod fs {
    pub fn exists<P: AsRef<Path>>(path: P) -> io::Result<bool>;
}

@rustbot

rustbot commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 7, 2024
@rust-lang rust-lang deleted a comment Jun 7, 2024
Amanieu
Amanieu reviewed Jun 10, 2024
View reviewed changes
Comment thread library/std/src/path.rs Outdated
/// prevent time-of-check to time-of-use (TOCTOU) bugs. You should only use it in scenarios
/// where those bugs are not an issue.
///
/// This is an alias to [`fs::exists`].

@Amanieu Amanieu Jun 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// This is an alias to [`fs::exists`].
/// This is an alias for [`std::fs::exists`].

@eduardosm eduardosm Jun 10, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Amanieu

Amanieu commented Jun 10, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 10, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 0637c43 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 11, 2024
Closed
@fmease

fmease commented Jun 11, 2024

Copy link
Copy Markdown
Member

#126252 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2024
@rustbot rustbot added O-hermit Operating System: Hermit O-solid Operating System: SOLID O-wasi Operating system: Wasi, Webassembly System Interface labels Jun 11, 2024
@eduardosm

eduardosm commented Jun 11, 2024

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2024
@Amanieu

Amanieu commented Jun 22, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 22, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 6a04dfe has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 22, 2024
Merged
@bors bors merged commit f3ced9d into rust-lang:master Jun 22, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 22, 2024
@bors

bors commented Jun 22, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6a04dfe with merge a0f01c3...

@eduardosm eduardosm deleted the stabilize-fs_try_exists branch June 22, 2024 21:44
@pheki pheki mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees

@Amanieu Amanieu

Labels

O-hermit Operating System: Hermit O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for fs_try_exists

6 participants

@eduardosm @rustbot @rust-log-analyzer @Amanieu @bors @fmease