Skip to content

refactor: remove ELAST across BSDs#5151

Open
dybucc wants to merge 1 commit into
rust-lang:mainfrom
dybucc:elast-removal
Open

refactor: remove ELAST across BSDs#5151
dybucc wants to merge 1 commit into
rust-lang:mainfrom
dybucc:elast-removal

Conversation

@dybucc

@dybucc dybucc commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

This PR completely removes the symbols that were deprecated in #5118. This follows from the comments
by @JohnTitor in [1]. In this instance, removal implies both deletion in the souce file where the
constant is declared and purging of the corresponding symbols in the SemVer-tracking file.

Sources

See #5118.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot

rustbot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in a NetBSD-like module

cc @semarie

Some changes occurred in an OpenBSD module

cc @semarie

@rustbot

This comment has been minimized.

@dybucc dybucc changed the title refactor: remove ELAST across bsds refactor: remove ELAST across BSDs Jun 8, 2026
@dybucc dybucc force-pushed the elast-removal branch 2 times, most recently from b1070bd to c8fc110 Compare June 8, 2026 13:46
@rustbot

This comment has been minimized.

This is a follow up from rust-lang#5118. That PR aimed for deprecation such the
proposed changes were included in the next stable release. This patch
completely removes the symbols for the 1.0 release.
@rustbot

rustbot commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@dybucc

dybucc commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

CI actually passes. There seems to be an issue with a glob import that is not used, but this has not
been changed in the patch (it's not even part of it, for that matter.) For some reason, rebasing
onto main with dependabot updates has ended up with a warning across all of my open PRs due to
that one (now apparently unused) import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants