refactor: remove *COUNT constants fitting #3131#5149
Open
dybucc wants to merge 1 commit into
Open
Conversation
Collaborator
*COUNT constants fitting #3131
5d00780 to
bcaa8a3
Compare
This comment has been minimized.
This comment has been minimized.
This patch is a follow up from rust-lang#5121. That PR deprecated the symbols for a stable release, while this patch ensures the symbols are altogether removed. See the accompanying PR for more details.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
CI actually passes. There seems to be an issue with a glob import that is not used, but this has not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR completely removes the symbols that were deprecated in #5121. This follows from the comments
by @JohnTitor in [1]. In this instance, removal implies both deletion in the souce file where the
constant is declared and purging of the corresponding symbols in the SemVer-tracking file.
There were a few symbols that did not have any SemVer plain text files tracking them. Those are
listed below.
HOST_CPU_LOAD_INFO_COUNTin Apple (unix/bsd/apple/mod.rs.)TASK_THREAD_TIMES_INFO_COUNTin Apple (unix/bsd/apple/mod.rs.)MACH_TASK_BASIC_INFO_COUNTin Apple (unix/bsd/apple/mod.rs.)HOST_VM_INFO64_COUNTin Apple (unix/bsd/apple/mod.rs.)LGRP_RSRC_COUNTin Illumos (unix/solarish/illumos/mod.rs.)Sources
See #5121.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI