ctest: probe optional compiler flags#5146
Open
chitao1234 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
TestGenerator::flag_if_supportedso ctest callers can request C compiler flags that should only be passed when the selected compiler supports them.This also changes ctest’s built-in warning suppressions for
-Wno-address-of-packed-memberand-Wno-unknown-warning-optionto usecc::Build::flag_if_supported. Some older toolchains (e.g. the default one on dragonfly) reject them when-Werroris enabled.The generated test compiler setup now sets the target before probing flags, so support checks use the same target configuration as the actual compile.
Sources
Not applicable.
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI