Skip to content

Fix bug in CMSG_NXTHDR for android.#1976

Closed
LinkTed wants to merge 1 commit into
rust-lang:masterfrom
LinkTed:master
Closed

Fix bug in CMSG_NXTHDR for android.#1976
LinkTed wants to merge 1 commit into
rust-lang:masterfrom
LinkTed:master

Conversation

@LinkTed

@LinkTed LinkTed commented Nov 15, 2020

Copy link
Copy Markdown
Contributor

CMSG_NXTHDR should return NULL if it is the last control message in the chain.

…L if it is the last control message in the chain.
@rust-highfive

Copy link
Copy Markdown

r? @JohnTitor

(rust_highfive has picked a reviewer for you, use r? to override)

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JohnTitor

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

📌 Commit 724d1a3 has been approved by JohnTitor

@bors

bors commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

⌛ Testing commit 724d1a3 with merge 9b6e9af...

bors added a commit that referenced this pull request Nov 23, 2020
Fix bug in `CMSG_NXTHDR` for android.

`CMSG_NXTHDR` should return NULL if it is the last control message in the chain.
@bors

bors commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-actions

@LinkTed

LinkTed commented Nov 23, 2020

Copy link
Copy Markdown
Contributor Author

It seems that the android implementation (bionic) is wrong. Should I close the PR?

@JohnTitor

Copy link
Copy Markdown
Member

Hm, if it's wrong and/or we don't need a fix for rust-lang/rust#69864, then yes.

@LinkTed LinkTed closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants