Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/ferrum/page.rb
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def subscribe

if @options.logger
on("Runtime.consoleAPICalled") do |params|
params["args"].each { |r| @options.logger.puts(r["value"]) }
log_console_api(params)
end
end

Expand Down Expand Up @@ -493,6 +493,16 @@ def prepare_page
document_node_id
end

def log_console_api(params)
message = params.fetch("args", []).filter_map { |arg| arg["value"] || arg["description"] }.join(" ")
@options.logger.puts("[#{params['type']}] #{message}")

params.dig("stackTrace", "callFrames")&.each do |frame|
location = "#{frame['url']}:#{frame['lineNumber'].to_i + 1}:#{frame['columnNumber'].to_i + 1}"
@options.logger.puts(" at #{frame['functionName']} (#{location})")
end
end

def inject_extensions
@options.extensions.each do |extension|
# https://github.com/GoogleChrome/puppeteer/issues/1443
Expand Down
3 changes: 3 additions & 0 deletions spec/browser_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@
browser = Ferrum::Browser.new(logger: logger)
browser.go_to(base_url("/console_log"))
expect(logger.string).to include("Hello world")
expect(logger.string).to include("[log] Hello world")
expect(logger.string).to include("at window.onload")
expect(logger.string).to include("/console_log")
ensure
browser&.quit
end
Expand Down
Loading