Qualify the README no-elevation claim for the VC++ Redistributable#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates rbmanager’s user-facing documentation and messaging to accurately describe the single elevation-required step (installing the machine-wide VC++ Redistributable) while keeping the “no elevation” claim scoped to rbmanager/per-user rubies, and aligns repo hygiene with the current build output layout.
Changes:
- Refines README wording around elevation requirements and documents the VC++ Redistributable/UAC flow.
- Updates the VC++ Redistributable missing-message to include the installer URL for admin handoff.
- Adds
artifacts/to.gitignoreto match the MSBuild artifacts layout.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Qualifies the no-elevation claim and documents the VC++ Redistributable exception and decline path. |
| rbmanager/VcRedist.cs | Improves user guidance by embedding the redistributable installer URL in the explanatory output. |
| .gitignore | Ignores artifacts/ build output. |
Comments suppressed due to low confidence (1)
rbmanager/VcRedist.cs:88
- The PR description says the consent prompt names the installer URL, but the interactive prompt still reads "Download and install it now?". Including the URL in the prompt itself makes it clearer what will be downloaded/installed (especially if the earlier explanatory text scrolls away).
rights, ask an administrator to install {InstallerUrl} instead.
""");
if (!assumeYes)
{
Console.Write("Download and install it now? [y/N] ");
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| which stands in for an installer until a winget manifest exists. | ||
|
|
||
| The official mswin packages deliberately do not bundle | ||
| vcruntime140.dll (https://bugs.ruby-lang.org/issues/22180) and expect |
| question or the UAC prompt leaves rbmanager and the installed rubies | ||
| intact; `rb setup` prints the installer URL so an administrator can | ||
| install it manually, and `rb install` / `rb use` merely warn that | ||
| ruby.exe cannot start until the runtime is present. |
The machine-wide VC++ Redistributable that `rb setup` offers to install cannot be installed without elevation, so scope the claim to rbmanager itself and the per-user rubies and document the UAC prompt and its decline path. The consent prompt now names the installer URL so a user without administrator rights knows what to hand to one. https://bugs.ruby-lang.org/issues/22180
hsbt
force-pushed
the
claude/recursing-wiles-a547bc
branch
from
21cc40a to
36f2cc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README claimed that no elevation is required at any point, but the machine-wide VC++ Redistributable that
rb setupoffers to install cannot be installed without elevation. The official mswin packages deliberately do not bundlevcruntime140.dll, so the per-machine install is unavoidable.https://bugs.ruby-lang.org/issues/22180
This scopes the README claim to rbmanager itself and the per-user rubies and documents the single UAC prompt and its decline path. The consent prompt now names the installer URL so a user without administrator rights knows what to ask an administrator to run.
rb installandrb usekeep warning without blocking.Also adds
artifacts/to.gitignore. The entry was missed when the build output moved to the MSBuild artifacts layout.