Fix test_kdf.rb in FIPS.#1054
Merged
Merged
Conversation
This was referenced May 20, 2026
rhenium
requested changes
May 22, 2026
junaruga
commented
May 25, 2026
junaruga
force-pushed
the
wip/fips-test-kdf
branch
from
6c82315 to
ffc54e8
Compare
Member
Author
|
@rhenium I fixed the things reviewed by you on the latest rebase, updating the commit message. Could you review again? Thank you. |
rhenium
reviewed
May 25, 2026
junaruga
force-pushed
the
wip/fips-test-kdf
branch
2 times, most recently
from
cb23294 to
4b5eba5
Compare
rhenium
reviewed
May 25, 2026
* PBKDF2 salt >= 16 bytes (128 bits) and iterations >= 1000 are required in FIPS. SP 800-132: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-132.pdf * 5.1 The Salt (S) https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/providers/implementations/kdfs/pbkdf2.c#L235-L240 * 5.2 The Iteration Count (C) https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/providers/implementations/kdfs/pbkdf2.c#L247-L252 * scrypt (RFC 7914) is not available in FIPS. EVP_KDF_fetch(ctx, OSSL_KDF_NAME_SCRYPT, propq) returns NULL in FIPS. https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/crypto/evp/pbe_scrypt.c#L67-L71 * Keep only one RFC 6070 test (test_pbkdf2_hmac_sha1_rfc6070_c_4096_len_25). Remove other RFC 6070 tests (test_*_rfc6070_*) don't work in FIPS. Keeping one RFC 6070 test is good enough. * Remove test_hkdf_rfc5869_test_case_4 in favor of the new test_hkdf_rfc5869_test_case_5. * We want to avoid conditional tests that don't work in FIPS as much as possible.
junaruga
force-pushed
the
wip/fips-test-kdf
branch
from
4b5eba5 to
450721c
Compare
Member
Author
|
@rhenium I fixed the things reviewed by you on the latest rebase, updating the commit message again. Could you review again? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed test_kdf.rb in FIPS.
SP 800-132: https://nvlpubs.nist.gov/nistpubs/Legacy/SP/nistspecialpublication800-132.pdf
https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/providers/implementations/kdfs/pbkdf2.c#L235-L240
https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/providers/implementations/kdfs/pbkdf2.c#L247-L252
EVP_KDF_fetch(ctx, OSSL_KDF_NAME_SCRYPT, propq) returns NULL in FIPS.
https://github.com/openssl/openssl/blob/71943544885ff364a10bcc5ffc62d0e651c9a021/crypto/evp/pbe_scrypt.c#L67-L71
less than the minimal key length 112 bits.