Skip to content

Ruby 3.4 and refactor swagger documentation modules#976

Open
moskvin wants to merge 20 commits into
ruby-grape:masterfrom
moskvin:master
Open

Ruby 3.4 and refactor swagger documentation modules#976
moskvin wants to merge 20 commits into
ruby-grape:masterfrom
moskvin:master

Conversation

@moskvin
Copy link
Copy Markdown

@moskvin moskvin commented May 11, 2026

  • Aligns lint configuration with Ruby 3.4 target.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Danger Report

No issues found.

View run

@moskvin moskvin changed the title [dev] Ruby 3.4 Ruby 3.4 and refactor swagger documentation modules May 11, 2026
@numbata numbata self-requested a review May 11, 2026 15:29
@moskvin
Copy link
Copy Markdown
Author

moskvin commented May 12, 2026

I've to drop support the old grape version to make CI happy

@moskvin
Copy link
Copy Markdown
Author

moskvin commented May 12, 2026

I would suggest to dropping ruby 3.1 from CI

@moskvin
Copy link
Copy Markdown
Author

moskvin commented May 12, 2026

@numbata please have a look again - I've removed some weird changes

@numbata
Copy link
Copy Markdown
Contributor

numbata commented May 12, 2026

@moskvin Thx for contribution!
I'll review the PR later today. Hope it is okay for you.

Copy link
Copy Markdown
Contributor

@numbata numbata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Very good job 👍

Main things before this can merge: the CI matrix now starts at Grape 2.4.0 but the gemspec still says >= 1.7, so either the gemspec needs updating or we should keep at least one older entry. And SwaggerRouting/SwaggerDocumentationAdder sitting at the top level is a collision risk, as now that they have their own files it's a good moment to nest them under GrapeSwagger::.

The triple lookup and test issues are in the inline comments. The dead-code comment and each_key signature are minor but easy to fix while you're already touching those lines.

Comment thread lib/grape-swagger/swagger_routing.rb Outdated
Comment thread lib/grape-swagger/request_param_parsers/route.rb Outdated
Comment thread .github/workflows/ci.yml
Comment thread lib/grape-swagger/swagger_routing.rb Outdated
Comment thread lib/grape-swagger/swagger_routing.rb Outdated
Comment thread spec/lib/request_param_parsers/route_spec.rb Outdated
@moskvin moskvin requested a review from numbata May 17, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants