Cpp20 part2

[ahcorde]

• Lambda over std::bind
• typedef→using in the two headers
• [[nodiscard]] on the factories and pure queries of both ClassLoader and MultiLibraryClassLoader

@asymingt FYI

Claude Opus 4.7

[pum1k]

The [[nodiscard]] causes warnings when compiling tests. Maybe explicitly ignore the result in those cases?

diff --git a/test/unique_ptr_test.cpp b/test/unique_ptr_test.cpp
index eb9f8a1..c2a6f7b 100644
--- a/test/unique_ptr_test.cpp
+++ b/test/unique_ptr_test.cpp
@@ -119,7 +119,8 @@ TEST(ClassLoaderUniquePtrTest, basicLoadFailures) {
 TEST(ClassLoaderUniquePtrTest, MultiLibraryClassLoaderFailures) {
   class_loader::MultiLibraryClassLoader loader(true);
   loader.loadLibrary(LIBRARY_1);
-  EXPECT_THROW(loader.createUniqueInstance<Base>("Cat2"), class_loader::ClassLoaderException);
+  EXPECT_THROW(std::ignore = loader.createUniqueInstance<Base>("Cat2"),
+    class_loader::ClassLoaderException);
 }
 
 TEST(ClassLoaderUniquePtrTest, LibrariesUsedByClassLoader) {
diff --git a/test/utest.cpp b/test/utest.cpp
index 2870f6b..754ee4a 100644
--- a/test/utest.cpp
+++ b/test/utest.cpp
@@ -163,7 +163,8 @@ TEST(ClassLoaderUniquePtrTest, basicLoadFailures) {
 TEST(ClassLoaderUniquePtrTest, MultiLibraryClassLoaderFailures) {
   class_loader::MultiLibraryClassLoader loader(true);
   loader.loadLibrary(LIBRARY_1);
-  EXPECT_THROW(loader.createUniqueInstance<Base>("Cat2"), class_loader::ClassLoaderException);
+  EXPECT_THROW(std::ignore = loader.createUniqueInstance<Base>("Cat2"),
+    class_loader::ClassLoaderException);
 }
 
 TEST(ClassLoaderTest, correctNonLazyLoadUnload) {

[asymingt]

[[nodiscard]] is so pedantic. I don't really think its required in the places you added it, but I also think it isn't harmful adding it. Please add the change requested from @pum1k before merging.

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[ahcorde]

Pulls: #229
Gist: https://gist.githubusercontent.com/ahcorde/e99b83fcbb0db9a426bf4f0a588e1225/raw/2417f0f065aaee45be6c31f2131cc3d0bbed33f0/ros2.repos
BUILD args: --packages-above-and-dependencies class_loader
TEST args: --packages-above class_loader
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19719

• Linux
• Linux-aarch64
• Linux-rhel
• Windows