Include CPP20 and related changes#228
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
asymingt
left a comment
asymingt
left a comment
There was a problem hiding this comment.
Happy in general with the change. Just one question about c++ standard srtting with ament_cmake_ros_core.
| PUBLIC ${console_bridge_INCLUDE_DIRS}) | ||
| target_link_libraries(${PROJECT_NAME} ${console_bridge_LIBRARIES}) | ||
| # Standalone (non-ament) build: request C++20 for our own translation units. | ||
| target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_20) |
There was a problem hiding this comment.
Should we not be using something from ament_cmake_ros_core here in stead of a hard-coded cxx_std_20. I am asking because it seems to me that the purpose of ament_cmake_ros_core is to abstract away from specific standards, so they my be universally set in a central location.
There was a problem hiding this comment.
This is for the case where we are not using ament
|
Tick the box to add this pull request to the merge queue (same as
|
|
Pulls: #228
|
2 participants
@asymingt FYI