Skip to content

Adding support for google/protobuf v4.x #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
butschster merged 1 commit into from
Jan 26, 2026
Merged

Adding support for google/protobuf v4.x #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"roadrunner-php/roadrunner-api-dto": "^1.4",
"spiral/roadrunner": "^2023.2 || ^2024.1 || ^2025.1",
"spiral/goridge": "^4.0",
"google/protobuf": "^3.7"
"google/protobuf": "^3.7 || ^4.0"

@coderabbitai coderabbitai Bot Jan 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

# First, let's check the composer.json file to see the actual state
cd /tmp && find . -name "composer.json" -type f 2>/dev/null | head -1

Repository: roadrunner-php/services

Length of output: 49

🏁 Script executed:

# List files to understand repo structure
git ls-files | grep -E "composer\.(json|lock)" | head -5

Repository: roadrunner-php/services

Length of output: 80

🏁 Script executed:

# Read the composer.json file
cat composer.json

Repository: roadrunner-php/services

Length of output: 1978

🏁 Script executed:

# Check roadrunner-api-dto from Packagist
curl -s "https://packagist.org/packages/roadrunner-php/roadrunner-api-dto.json" | jq -r '.package | {latest_release: .releases | keys[0], versions: (.versions | keys | .[:5])}' 2>/dev/null || echo "Failed to fetch"

Repository: roadrunner-php/services

Length of output: 82

🏁 Script executed:

# Get more details on roadrunner-api-dto latest version
curl -s "https://packagist.org/packages/roadrunner-php/roadrunner-api-dto.json" | jq -r '.package.versions | to_entries | sort_by(.key) | reverse | .[0] | {version: .key, require: .value.require}' 2>/dev/null || echo "Failed"

Repository: roadrunner-php/services

Length of output: 170

Update protobuf constraint to match roadrunner-api-dto requirement.

The constraint should be "^3.22 || ^4.0" instead of "^3.7 || ^4.0". The roadrunner-api-dto dependency (v1.9.0 latest) requires google/protobuf: "^3.22 || ^4.0", which means protobuf versions 3.7–3.21 would satisfy your project's constraint but fail to satisfy the transitive dependency constraint. This creates a potential version resolution conflict.

Align the protobuf constraint with the transitive dependency requirement to prevent dependency resolution issues:

Suggested change 
-        "google/protobuf": "^3.7 || ^4.0"
+        "google/protobuf": "^3.22 || ^4.0"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"google/protobuf": "^3.7 || ^4.0"
"google/protobuf": "^3.22 || ^4.0"
🤖 Prompt for AI Agents 
In `@composer.json` at line 42, The composer.json protobuf version constraint is
too permissive ("google/protobuf": "^3.7 || ^4.0") and can conflict with
roadrunner-api-dto; update the constraint to "google/protobuf": "^3.22 || ^4.0"
to match the roadrunner-api-dto requirement, ensuring dependency resolution
consistency—edit the composer.json entry for the google/protobuf package
accordingly.

},
"autoload": {
"psr-4": {
Expand Down
Loading