You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MilesModelUpdateService claims NCCL rendezvous ports in SharedStorage while building sync plans. The MILES path recorded the claim but never released it after the cache-owner transport completed, so successful syncs could leave stale MASTER_ADDR_PORT:* keys behind over a long-running job.
Reviewed this as part of the F1-F12 code review — supportive. Two notes before merge:
The failure/timeout path still leaks the claim. This PR releases on the successful-transport path (_release_port_claim fires right after run_sync_session returns — correct placement, since the port is only needed for the NCCL rendezvous during transport). But if run_sync_session raises, or the atomic unit's asyncio.wait_for cancels mid-flight (_cancel_inflight fires ray.cancel on the inflight refs but never releases the port), _release_port_claim is skipped and the claim lingers until orchestrator.kill_pipeline's delete_port_claims. Since every sync claims a fresh MASTER_ADDR_PORT:{addr}:{port} key, repeated failures still grow the claim table, and OS port reuse can collide with stale claims and burn the 8-attempt retry budget. Suggestion: keep the current post-transport release, and additionally release in the timeout/cancellation handler (or restructure as try/finally around the transport step).
The claim currently serves a dead path.master_addr/port is only consumed by the NCCL broadcast transport, and that path is double-guarded with NotImplementedError (service-side sync_selected_workers L177-190, miles-side _dispatch_nccl_broadcast P1-8 self-guard). cpu_serialize never touches the port. An alternative to hardening the release: skip claiming entirely until broadcast lands — which would also intersect with delete unimplemented broadcast transport path [need discussion] #24's discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
MilesModelUpdateService claims NCCL rendezvous ports in SharedStorage while building sync plans. The MILES path recorded the claim but never released it after the cache-owner transport completed, so successful syncs could leave stale
MASTER_ADDR_PORT:*keys behind over a long-running job.