Fix numeric strings being misinterpreted as binary strings#81
Open
bpbp-boop wants to merge 1 commit into
Open
Conversation
…s/minus IPBlock iteration passes the position to IP::plus() as a decimal string. The IPv4 constructor's auto-detection treats any 4-character string as a packed binary string, so once the position reached 1000 the string "1000" was read as the bytes 0x31303030 (825241648) instead of the number 1000, yielding addresses far outside the block. IP::plus() and IP::minus() now convert digit-only strings with initGmpFromNumericString() instead of the auto-detecting constructor, and IPBlock::getIterator() passes the GMP position directly. Fixes rlanvin#74 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IPBlock iteration passes the position to IP::plus() as a decimal string. The IPv4 constructor's auto-detection treats any 4-character string as a packed binary string, so once the position reached 1000 the string "1000" was read as the bytes 0x31303030 (825241648) instead of the number 1000, yielding addresses far outside the block.
IP::plus() and IP::minus() now convert digit-only strings with initGmpFromNumericString() instead of the auto-detecting constructor, and IPBlock::getIterator() passes the GMP position directly.
Fixes #74