Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions engine/packages/depot/src/conveyer/types/branch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,14 @@ impl OwnedVersionedData for VersionedDatabaseBranchRecord {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::Current(serde_bare::from_slice(payload)?)),
1 => Ok(Self::Current(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot DatabaseBranchRecord version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::Current(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::Current(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand All @@ -108,14 +108,14 @@ impl OwnedVersionedData for VersionedDatabasePointer {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot DatabasePointer version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand All @@ -139,14 +139,14 @@ impl OwnedVersionedData for VersionedBucketBranchRecord {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot BucketBranchRecord version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand All @@ -170,14 +170,14 @@ impl OwnedVersionedData for VersionedBucketPointer {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot BucketPointer version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand All @@ -201,14 +201,14 @@ impl OwnedVersionedData for VersionedPointerSnapshot {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot PointerSnapshot version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions engine/packages/depot/src/conveyer/types/compaction.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,14 @@ macro_rules! impl_compaction_versioned_data {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot {} version: {version}", $name),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions engine/packages/depot/src/conveyer/types/history_pin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ impl OwnedVersionedData for VersionedDbHistoryPin {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot DbHistoryPin version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions engine/packages/depot/src/conveyer/types/policy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ impl OwnedVersionedData for VersionedPitrPolicy {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot PitrPolicy version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(policy) => serde_bare::to_vec(&policy).map_err(Into::into),
Self::V1(policy) => rivet_util::serde::bare_to_vec!(&policy).map_err(Into::into),
}
}
}
Expand All @@ -86,14 +86,14 @@ impl OwnedVersionedData for VersionedShardCachePolicy {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot ShardCachePolicy version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(policy) => serde_bare::to_vec(&policy).map_err(Into::into),
Self::V1(policy) => rivet_util::serde::bare_to_vec!(&policy).map_err(Into::into),
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions engine/packages/depot/src/conveyer/types/restore_points.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,14 @@ impl OwnedVersionedData for VersionedRestorePointRecord {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot RestorePointRecord version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions engine/packages/depot/src/conveyer/types/storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@ impl OwnedVersionedData for VersionedDBHead {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot DBHead version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand All @@ -84,14 +84,14 @@ impl OwnedVersionedData for VersionedCommitRow {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot CommitRow version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand All @@ -115,14 +115,14 @@ impl OwnedVersionedData for VersionedMetaCompact {

fn deserialize_version(payload: &[u8], version: u16) -> Result<Self> {
match version {
1 => Ok(Self::V1(serde_bare::from_slice(payload)?)),
1 => Ok(Self::V1(rivet_util::serde::bare_from_slice!(payload)?)),
_ => bail!("invalid depot MetaCompact version: {version}"),
}
}

fn serialize_version(self, _version: u16) -> Result<Vec<u8>> {
match self {
Self::V1(data) => serde_bare::to_vec(&data).map_err(Into::into),
Self::V1(data) => rivet_util::serde::bare_to_vec!(&data).map_err(Into::into),
}
}
}
Expand Down
22 changes: 12 additions & 10 deletions engine/packages/engine/src/commands/udb/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -929,21 +929,23 @@ impl SubCommand {
// A v2 entry roundtrips byte-identically through the v2
// schema. v3 entries either fail to deserialize as v2 or
// re-serialize to different bytes, so they are ignored.
let v2_entry: proto_v2::ChangelogEntry =
match serde_bare::from_slice(entry.value()) {
Ok(v) => v,
Err(_) => {
v3_count += 1;
continue;
}
};
let reserialized = match serde_bare::to_vec(&v2_entry) {
Ok(b) => b,
let v2_entry: proto_v2::ChangelogEntry = match rivet_util::serde::bare_from_slice!(
entry.value()
) {
Ok(v) => v,
Err(_) => {
v3_count += 1;
continue;
}
};
let reserialized =
match rivet_util::serde::bare_to_vec!(&v2_entry) {
Ok(b) => b,
Err(_) => {
v3_count += 1;
continue;
}
};
if reserialized != entry.value() {
v3_count += 1;
continue;
Expand Down
5 changes: 3 additions & 2 deletions engine/packages/epoxy/src/http_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ async fn send_request_to_address(
let client = rivet_pools::reqwest::client().await?;

// Create the request
let request = serde_bare::to_vec(&request).context("failed to serialize epoxy request")?;
let request =
rivet_util::serde::bare_to_vec!(&request).context("failed to serialize epoxy request")?;

// Send the request
let response_result = client
Expand Down Expand Up @@ -223,7 +224,7 @@ async fn send_request_to_address(
}

let body = response.bytes().await?;
let response_body = serde_bare::from_slice(&body)?;
let response_body = rivet_util::serde::bare_from_slice!(&body)?;

tracing::debug!(
to_replica = to_replica_id,
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/epoxy/src/http_routes.rs
Original file line number Diff line number Diff line change
Expand Up @@ -91,5 +91,5 @@ async fn handle_request(ctx: ApiCtx, request: protocol::Request) -> Result<Vec<u
metrics::record_request_result(kind_label, result_label);
perf_finish!(measure, fields: { result = %result_label });

serde_bare::to_vec(&res?).map_err(Into::into)
rivet_util::serde::bare_to_vec!(&res?).map_err(Into::into)
}
12 changes: 6 additions & 6 deletions engine/packages/epoxy/src/keys/keys.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,11 @@ impl FormalKey for KvBallotKey {
type Value = protocol::Ballot;

fn deserialize(&self, raw: &[u8]) -> Result<Self::Value> {
serde_bare::from_slice(raw).map_err(Into::into)
rivet_util::serde::bare_from_slice!(raw).map_err(Into::into)
}

fn serialize(&self, value: Self::Value) -> Result<Vec<u8>> {
serde_bare::to_vec(&value).map_err(Into::into)
rivet_util::serde::bare_to_vec!(&value).map_err(Into::into)
}
}

Expand Down Expand Up @@ -203,11 +203,11 @@ impl FormalKey for KvAcceptedKey {
type Value = KvAcceptedValue;

fn deserialize(&self, raw: &[u8]) -> Result<Self::Value> {
serde_bare::from_slice(raw).map_err(Into::into)
rivet_util::serde::bare_from_slice!(raw).map_err(Into::into)
}

fn serialize(&self, value: Self::Value) -> Result<Vec<u8>> {
serde_bare::to_vec(&value).map_err(Into::into)
rivet_util::serde::bare_to_vec!(&value).map_err(Into::into)
}
}

Expand Down Expand Up @@ -368,11 +368,11 @@ impl FormalKey for ChangelogKey {
// TODO: this is mistakenly not versioned. Transition to vbare so future
// changes to ChangelogEntry don't require hand-rolled LegacyXxx fallbacks.
fn deserialize(&self, raw: &[u8]) -> Result<Self::Value> {
serde_bare::from_slice(raw).map_err(Into::into)
rivet_util::serde::bare_from_slice!(raw).map_err(Into::into)
}

fn serialize(&self, value: Self::Value) -> Result<Vec<u8>> {
serde_bare::to_vec(&value).map_err(Into::into)
rivet_util::serde::bare_to_vec!(&value).map_err(Into::into)
}
}

Expand Down
4 changes: 2 additions & 2 deletions engine/packages/epoxy/src/keys/replica.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ impl FormalKey for ConfigKey {
// TODO: this is mistakenly not versioned. Transition to vbare so future
// changes to ClusterConfig don't require hand-rolled LegacyXxx fallbacks.
fn deserialize(&self, raw: &[u8]) -> Result<Self::Value> {
serde_bare::from_slice(raw).map_err(Into::into)
rivet_util::serde::bare_from_slice!(raw).map_err(Into::into)
}

fn serialize(&self, value: Self::Value) -> Result<Vec<u8>> {
serde_bare::to_vec(&value).map_err(Into::into)
rivet_util::serde::bare_to_vec!(&value).map_err(Into::into)
}
}

Expand Down
2 changes: 1 addition & 1 deletion engine/packages/gasoline/src/workflow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl<'a, T: DeserializeOwned + Serialize> StateGuard<'a, T> {
pub(crate) fn new(
guard: MutexGuard<'a, (Box<serde_json::value::RawValue>, bool)>,
) -> Result<Self> {
let value = rivet_util::observe!(serde_json::from_str::<T>(guard.0.get())?);
let value = rivet_util::serde::json_from_str!(guard.0.get())?;

Ok(Self {
guard,
Expand Down
1 change: 1 addition & 0 deletions engine/packages/pegboard-runner/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ rivet-metrics.workspace = true
rivet-runner-protocol.workspace = true
rivet-runtime.workspace = true
rivet-types.workspace = true
rivet-util.workspace = true
scc.workspace = true
serde_bare.workspace = true
serde_json.workspace = true
Expand Down
4 changes: 2 additions & 2 deletions engine/packages/pegboard-runner/src/ws_to_tunnel_task.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1028,15 +1028,15 @@ async fn compat_ack_tunnel_message(conn: &Conn, payload: &[u8]) -> Result<()> {
use rivet_runner_protocol::generated::v2 as protocol_v2;

// Parse payload
let msg = serde_bare::from_slice::<protocol_v2::ToServer>(&payload)?;
let msg: protocol_v2::ToServer = rivet_util::serde::bare_from_slice!(&payload)?;
let protocol_v2::ToServer::ToServerTunnelMessage(msg) = msg else {
return Ok(());
};

tracing::debug!(?msg.request_id, ?msg.message_id, "sending v2 compat tunnel ack");

// Serialize response
let ack_msg = serde_bare::to_vec(&protocol_v2::ToClient::ToClientTunnelMessage(
let ack_msg = rivet_util::serde::bare_to_vec!(&protocol_v2::ToClient::ToClientTunnelMessage(
protocol_v2::ToClientTunnelMessage {
request_id: msg.request_id,
message_id: msg.message_id,
Expand Down
Loading
Loading