Goal gate fails closed on unreadable events.jsonl (#200)#205
Conversation
) Goal-activity detection read events.jsonl through a tolerant reader that returns [] on failure, so a corrupt/lost event log on a recipe-driven run made the stage-11 gate report 'no active goal' and PASS without requiring goal_evaluation — fail-open. activeGoalContext now distinguishes an absent log (genuine non-goal run) from one that exists but yields zero parseable events or can't be read (indeterminate), and the gate returns a goal_activity_indeterminate FAIL. Documents the permanent-activity + fail- closed behavior in HARNESS.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
From PR #198's adversarial review (finding F1, should-fix). A recipe-driven run proves goal context only through
events.jsonl; the tolerant reader returned[]on read failure, so a corrupt/lost event log silently disarmed the stage-11 goal gate (fail-open).activeGoalContextnow distinguishes an absent log (a genuine non-goal run — stays optional) from one that exists but is unreadable or yields zero parseable events (indeterminate →goal_activity_indeterminateFAIL). A legitimately empty log is not corrupt. Folds in the N1 doc nit: goal-activity is permanent, documented in HARNESS.md.Closes #200.
🤖 Generated with Claude Code