Harden TIFF parsing/index bounds and split Python binding concerns from core library#3
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/rhayman/ScanImageTiffIO/sessions/cd3ddb39-9b4b-4521-934a-5b3278bef383 Co-authored-by: rhayman <5619644+rhayman@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rhayman/ScanImageTiffIO/sessions/cd3ddb39-9b4b-4521-934a-5b3278bef383 Co-authored-by: rhayman <5619644+rhayman@users.noreply.github.com>
Agent-Logs-Url: https://github.com/rhayman/ScanImageTiffIO/sessions/cd3ddb39-9b4b-4521-934a-5b3278bef383 Co-authored-by: rhayman <5619644+rhayman@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rhayman
May 21, 2026 11:01
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses three coupled issues: unsafe parsing/index assumptions in TIFF/log handling, tight Python-binding coupling in the C++ core API, and stale repository/build metadata. The update hardens input handling and frame/channel indexing while separating core library concerns from Python interop.
Parsing and index hardening
LUT, offsets, saved channels).setChannel,readFrame,writeFrame,tail, andsaveTiffTail.Core/Python decoupling
include/ScanImageTiff.h).readFrame -> arma::Mat<int16_t>,tail -> arma::Cube<int16_t>tuple).src/ScanImageTiffPy.cpp) via binding lambdas.Build graph and stale metadata cleanup
BUILD_PYTHON_BINDINGSflow with explicit dependency failure messaging..gitmodulessubmodule metadata.