Moving to generic methods inside TRestRawSignal

[juanangp]

Using generic methods inside TRestRawSignal after being implemented inside framework rest-for-physics/framework#379

Summary of changes:

• Implementing generic methods inside TRestRawSignal
• Moving fPointsOverThreshold from std::vector<Int_t> to std::vector<std::pair<Float_t, Float_t> >
• New function GetData which returns std::vector<Float_t> vector with the baseline substracted

[jgalan]

What about TRestRawSignal inheriting from TRestPulseShapeAnalysis?

[nkx111]

Better to have fPointsOverThreshold in correspondence with TRestRawSignal's data structure. x should be time bin(int) and y should be amplitude(unsigned short). Therefore the returned type should be std::vector<std::pair<Int_t, UShort_t> >

[jgalan]

Yes, I didn't notice this, I also think it would make more sense <Int_t, UShort_t>

[juanangp]

Looking at the code fPointsOverThreshold corresponds to the points with the baseline substracted, so for me it doesn't make sense to return std::vector<std::pair<Int_t, Short_t> > since we will be loosing precision.

[juanangp]

What about TRestRawSignal inheriting from TRestPulseShapeAnalysis?

I dont' think this would be a good idea since TRestRawSignal would be inheriting twice. Moreover, in the current inplementation TRestPulseShapeAnalysis is a namespace so it is not possible to inherit. Perhaps, we can discuss this topic in the meeting.