feat(plotly): add per-chart locale support#6428
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Greptile SummaryThis PR adds per-chart locale support to
Confidence Score: 5/5Safe to merge — the locale prop is correctly gated, zero-cost for charts without it, and the render path handles both static and state-driven configs without regressions. The conditional import and custom-code pattern mirrors No files require special attention. Important Files Changed
Reviews (4): Last reviewed commit: "add integration test for plotly charts w..." | Re-trigger Greptile |
…t subclasses - Gate plotly.js-locales import behind locale prop (follows moment.py pattern) - Gate locale helper custom code behind locale prop - Fix all dist-variant subclasses to inherit parent imports via super() - Update pyi_hashes.json for regenerated plotly.pyi
# Conflicts: # pyi_hashes.json
…classes The add_imports interface already merges imports from parent classes, so calling super().add_imports() explicitly is unnecessary. Subclasses now just return their own additions.
All Submissions:
Type of change
New Feature Submission:
Changes To Core Features:
Description
Adds first-pass Plotly locale support on
x.plotly and plotly dist variants via a new locale prop.
What changed:
x.plotly(...) and
x.plotly.basic(...) locale flow.
Validation:
Closes #6101