fix: update Go version to 1.26.2 and fix format string in fmt.Errorf#111
Open
hectorespert wants to merge 3 commits into
Open
fix: update Go version to 1.26.2 and fix format string in fmt.Errorf#111hectorespert wants to merge 3 commits into
hectorespert wants to merge 3 commits into
Conversation
- Update go.mod to Go 1.26.2 - Update workflow to use Go 1.26.2 - Fix non-constant format string error in ads1x15/factory.go - Go 1.26.2 enforces constant format strings for fmt.Errorf - All tests passing locally Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Remove codecov/codecov-action@v1 (deprecated) - Update go test to generate coverage.txt: go test -coverprofile=coverage.txt ./... - Add Coveralls upload action (coverallsapp/github-action@v2) - Align with reef-pi root project coverage reporting method - All tests passing with coverage tracking Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the GitHub Actions workflow failure and aligns coverage reporting with the reef-pi root project.
Changes
go.modto specify Go 1.26.2 (was 1.23.2)ads1x15/factory.goto comply with Go 1.26.2's stricter fmt.Errorf requirementsgo test -coverprofile=coverage.txt ./...coverallsapp/github-action@v2Testing
go test ./...go build ./...Related Issue
Fixes GitHub Actions workflow failure in run #29149364650
Alignment with reef-pi
Coverage reporting now matches the root reef-pi project method using Coveralls instead of codecov.