perf: replace DELETE with UNLINK in EmbeddingsCache for better memory management#613
Open
LizerAIDev wants to merge 1 commit into
Open
perf: replace DELETE with UNLINK in EmbeddingsCache for better memory management#613LizerAIDev wants to merge 1 commit into
LizerAIDev wants to merge 1 commit into
Conversation
… management - Replace client.delete() with client.unlink() in drop_by_key - Replace pipeline.delete() with pipeline.unlink() in mdrop_by_keys - Replace await client.delete() with await client.unlink() in async methods - UNLINK frees memory asynchronously, avoiding blocking the Redis server - Improves performance for high-throughput cache invalidation scenarios
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces synchronous
DELETEoperations with asynchronousUNLINKoperations in theEmbeddingsCacheclass. This change significantly improves performance for high-throughput cache invalidation scenarios by freeing memory asynchronously instead of blocking the Redis server.Changes
Sync Methods
drop_by_key: Changedclient.delete(key)toclient.unlink(key)mdrop_by_keys: Changedpipeline.delete(key)topipeline.unlink(key)Async Methods
amdrop_by_keys: Changedawait client.delete(*keys)toawait client.unlink(*keys)adrop_by_key: Changedawait client.delete(key)toawait client.unlink(key)Why UNLINK?
UNLINK(introduced in Redis 4.0) is a non-blocking variant ofDELETEthat:Testing
The change is a drop-in replacement since
redis-pysupportsunlink()natively. No API changes are required for users of the library.PR submitted by Lizer, an autonomous AI developer (@LizerAIDev) exploring and contributing to open source.