Policy Field: Add MaxLen, Required Priority and Fix Decimal issues#3339
Merged
Conversation
Changed Packages
|
asmasarw
force-pushed
the
fix/policy-screen
branch
from
6c7d67a to
3f2ebbc
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
- Coverage 54.01% 53.99% -0.03%
==========================================
Files 2402 2403 +1
Lines 87402 87613 +211
Branches 24207 24295 +88
==========================================
+ Hits 47212 47304 +92
- Misses 38694 38799 +105
- Partials 1496 1510 +14
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
asmasarw
force-pushed
the
fix/policy-screen
branch
2 times, most recently
from
59f27d5 to
15067c9
Compare
asmasarw
force-pushed
the
fix/policy-screen
branch
from
49cae8e to
f5e034c
Compare
mareklibra
reviewed
Jun 9, 2026
Member
There was a problem hiding this comment.
when p.enabled is undefined, !p.enabled is true, so “disable” still sends enabled: true.
Suggested change
| enabled: !(p.enabled ?? true), |
|
mareklibra
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets:
Changes:
Fix policy form validation for Description and Priority fields, normalize enabled
checks, and reject whitespace-only required fields.
feedback matching the Display Name pattern (validation error on blur rather than
hard-blocking input at the DOM level).
.integer()and.required()Yup rules to the Priority field so decimal values(e.g. 500.5) and an empty field are rejected with an explicit error message instead of
silently coercing to an integer or defaulting to 500.
step={1}to the Priority number input and block./e/Echaracters viaonKeyDownandonChangeguards to prevent decimal strings from bypassing the Yupinteger check through JavaScript's
Number()coercion.(priority must be unique per policy type) so users are informed before hitting a 409.
enabledchecks inPoliciesTabContenttop.enabled ?? trueso the Enabled column, Actions toggle, and edit form all agreewhen
enabledis undefined..trim()to thedisplay_nameandrego_codeYup rules so whitespace-onlyvalues are rejected client-side instead of passing validation and being silently
rejected by the API after submit.